| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Meskes <meskes(at)postgresql(dot)org> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Warnings around booleans |
| Date: | 2015-08-13 11:29:17 |
| Message-ID: | 20150813112917.GA8988@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-08-13 13:27:33 +0200, Michael Meskes wrote:
> > Playing around a bit lead to to find that this is caused by a wrong type
> > declaration in two places. 'isarray' is declared as bool instead of enum
> > ARRAY_TYPE in two places. This appears to be an oversight, perhaps
> > caused by the boolean sounding name.
>
> I vaguely remember that it used to be bool back in the day.
I dug a bit back, but got tired of it around 2003 ;)
> > Does this look right to you? If so, will you apply it?
>
> Yes and yes. Thanks for spotting, fixed in master and the back branches.
Thanks!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-08-13 11:41:54 | Re: Warnings around booleans |
| Previous Message | Heikki Linnakangas | 2015-08-13 11:28:58 | Re: Warnings around booleans |