Re: pgsql: Add some comments to test_ddl_deparse and a README

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add some comments to test_ddl_deparse and a README
Date: 2015-07-20 09:40:59
Message-ID: 55ACC22B.3030708@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 07/20/2015 12:21 PM, Alvaro Herrera wrote:
> Add some comments to test_ddl_deparse and a README
>
> Per comments from Heikki Linnakangas.
>
> Backpatch to 9.5, where this module was introduced.

I already added the ReAddComment case there, and you get a compiler
error now:

est_ddl_deparse.c: In function ‘get_altertable_subcmdtypes’:
test_ddl_deparse.c:179:4: error: duplicate case value
case AT_ReAddComment:
^
test_ddl_deparse.c:155:4: error: previously used here
case AT_ReAddComment:
^

I'll let you fix that, so that I won't joggle your elbow again ;-)

- Heikki

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2015-07-20 09:46:47 Re: Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY
Previous Message Alvaro Herrera 2015-07-20 09:25:17 Re: Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY