From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Add some comments to test_ddl_deparse and a README |
Date: | 2015-07-20 09:52:10 |
Message-ID: | 20150720095209.GI2301@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Heikki Linnakangas wrote:
> On 07/20/2015 12:21 PM, Alvaro Herrera wrote:
> >Add some comments to test_ddl_deparse and a README
> >
> >Per comments from Heikki Linnakangas.
> >
> >Backpatch to 9.5, where this module was introduced.
>
> I already added the ReAddComment case there, and you get a compiler error
> now:
Wow, I mismerged and failed to realize. Bah.
> est_ddl_deparse.c: In function ‘get_altertable_subcmdtypes’:
> test_ddl_deparse.c:179:4: error: duplicate case value
> case AT_ReAddComment:
> ^
> test_ddl_deparse.c:155:4: error: previously used here
> case AT_ReAddComment:
> ^
>
> I'll let you fix that, so that I won't joggle your elbow again ;-)
Thanks
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2015-07-20 10:00:31 | pgsql: Fix mis-merge in previous commit |
Previous Message | Andres Freund | 2015-07-20 09:46:47 | Re: Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY |