Re: [PATCH] Identify LWLocks in tracepoints

From: David Steele <david(at)pgmasters(dot)net>
To: Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: [PATCH] Identify LWLocks in tracepoints
Date: 2021-03-03 12:50:22
Message-ID: 5593d14c-1916-2deb-6946-0cd9d3f2e8e6@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/22/21 6:02 AM, Peter Eisentraut wrote:
> On 2021-01-14 09:39, Craig Ringer wrote:
>> On Thu, 14 Jan 2021 at 15:56, Peter Eisentraut
>> <peter(dot)eisentraut(at)enterprisedb(dot)com
>> <mailto:peter(dot)eisentraut(at)enterprisedb(dot)com>> wrote:
>>
>>     On 2020-12-19 06:00, Craig Ringer wrote:
>>      > Patch 1 fixes a bogus tracepoint where an lwlock__acquire event
>>     would be
>>      > fired from LWLockWaitForVar, despite that function never actually
>>      > acquiring the lock.
>>
>>     This was added in 68a2e52bbaf when LWLockWaitForVar() was first
>>     introduced.  It looks like a mistake to me too, but maybe Heikki
>> wants
>>     to comment.
>>
>>
>> I'm certain it's a copy/paste bug.
>
> I have committed that patch.

This patch set no longer applies:
http://cfbot.cputube.org/patch_32_2927.log.

Can we get a rebase? Also marked Waiting on Author.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2021-03-03 12:56:43 Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW
Previous Message David Steele 2021-03-03 12:37:02 Re: archive_command / pg_stat_archiver & documentation