Re: Windows now has fdatasync()

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> ... I was just noting an upcoming
> opportunity to remove the configure/meson probes for fdatasync, which
> made me feel better about the slightly kludgy way this patch is
> defining HAVE_FDATASYNC explicitly on Windows.

Hm. There is certainly not any harm in the meson infrastructure
skipping that test, because prairiedog is not able to run meson
anyway. Can we do that and still leave it in place on the autoconf
side? Maybe not, because I suppose you want to remove #ifdefs in
the code itself.

I see that fdatasync goes back as far as SUS v2, which we've long
taken as our minimum POSIX infrastructure. So there's not a lot
of room to insist that we should support allegedly-Unix platforms
without it.

regards, tom lane