| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove redundant initializations |
| Date: | 2021-06-30 13:28:17 |
| Message-ID: | 555366.1625059697@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Tue, 29 Jun 2021 at 02:15, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The primary case where I personally rely on that style is when adding a
>> new field to a struct. Currently it's possible to grep for some existing
>> field and add the new one beside it. Leaving out initializations by
>> relying on side-effects of makeNode makes that far riskier.
> FWIW, I mostly grep for makeNode(NameOfNode) as I'm a bit mistrusting
> of if the random existing field name that I pick to grep for will
> properly showing me all the locations I should touch.
I tend to do that too, but it's not a foolproof thing either, since
some places use random memset's for the purpose.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2021-06-30 13:30:53 | Re: cleaning up PostgresNode.pm |
| Previous Message | Alvaro Herrera | 2021-06-30 13:10:06 | Re: Preventing abort() and exit() calls in libpq |