Re: Preventing abort() and exit() calls in libpq

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Jacob Champion <pchampion(at)vmware(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, info(at)cspug(dot)cz
Subject: Re: Preventing abort() and exit() calls in libpq
Date: 2021-06-30 13:10:06
Message-ID: 202106301310.hcgqcu3dxumf@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Jun-30, Alvaro Herrera wrote:

> On 2021-Jun-29, Tom Lane wrote:
>
> > Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > > Ah, I nm'd all files in src/interfaces/libpq and got no hits for abort.
> > > But I did get one in libpgport_shlib.a:
> >
> > > path_shlib.o:
> > > U abort
> >
> > Yeah, there is one in get_progname(). But path.o shouldn't be getting
> > pulled into libpq ... else why aren't all the animals failing?
>
> Maybe there's something about the linker flags being used.
>
> ... ah yeah, if I configure with coverage enabled on my machine, it fails in the same way.

If I remove -fprofile-arcs from CFLAGS, then abort is no longer present,
but we still get a fail because of __gcov_exit. I suppose if you'd add
an exception for __cxa_atexit, the same place could use one for
__gcov_exit.

I'm not sure what to make of the -fprofile-arcs stuff though.

--
Álvaro Herrera Valdivia, Chile
https://www.EnterpriseDB.com/
"Java is clearly an example of money oriented programming" (A. Stepanov)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-06-30 13:28:17 Re: Remove redundant initializations
Previous Message Alvaro Herrera 2021-06-30 12:58:31 Re: Preventing abort() and exit() calls in libpq