| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: HAVE_WORKING_LINK still needed? |
| Date: | 2020-03-04 16:37:23 |
| Message-ID: | 5473cecc-4d33-18ab-287d-6f8fb26d52db@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-02-28 19:44, Alvaro Herrera wrote:
> On 2020-Feb-28, Tom Lane wrote:
>
>> Also +1 for s/durable_link_or_rename/durable_link/.
>
> Actually, it's not *that* either, because what the function does is link
> followed by unlink. So it's more a variation of durable_rename with
> slightly different semantics -- the difference is what happens if a file
> with the target name already exists. Maybe call it durable_rename_no_overwrite.
I have committed the first two patches.
Here is the third patch again, we renaming durable_link_or_rename() to
durable_rename_excl(). This seems to match existing Unix system call
naming best (see open() flag O_EXCL, and macOS has a renamex_np() flag
RENAME_EXCL).
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Remove-HAVE_WORKING_LINK.patch | text/plain | 5.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2020-03-04 16:39:19 | Re: Option to dump foreign data in pg_dump |
| Previous Message | Dean Rasheed | 2020-03-04 16:37:05 | Re: Some improvements to numeric sqrt() and ln() |