Re: Protocol de-synchronisation bug, bogus query sent

From: "Inoue, Hiroshi" <inoue(at)tpf(dot)co(dot)jp>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: "pgsql-odbc(at)postgresql(dot)org" <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: Protocol de-synchronisation bug, bogus query sent
Date: 2014-06-20 03:27:28
Message-ID: 53A3AA20.5020800@tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

(2014/06/20 10:55), Craig Ringer wrote:
> On 06/20/2014 08:29 AM, Craig Ringer wrote:
>> On 06/19/2014 08:08 PM, Hiroshi Inoue wrote:
>>> (2014/06/19 11:47), Craig Ringer wrote:
>>>> On 06/19/2014 12:56 PM, Craig Ringer wrote:
>>>>>
>>>>> and we're attempting to use the version obtained from the server before
>>>>> we have it, instead of the conninfo-specified version to use for
>>>>> protocol selection purposes.
>>>>
>>>> The attached patch fixes this.
>>>
>>> Thanks.
>>> I would also check the source of this trouble.
>>
>> Huh?
>>
>> That _is_ the source of this trouble. Some code that runs during
>> connection setup, before the server version is available, tries to use
>> the version obtained from the server instead of the protocol version
>> requested in the conninfo.
>
> Just to clarify, only the 0002 patch is required. My branch at:
>
> https://github.com/ringerc/psqlodbc/tree/fix-febe-protocol-desync-emptyquery
>
> only contains the second patch. I've attached a revised version that
> should make that clearer.
>
> Please apply / pull.

Thanks.
Applied.

I also pushd another change. It fixes another (or a real) cause of
this problem. I borrowed your beforeV2 in it. Thanks again.

regards,
Hiroshi Inoue

--
I am using the free version of SPAMfighter.
SPAMfighter has removed 10986 of my spam emails to date.
Get the free SPAMfighter here: http://www.spamfighter.com/len

Do you have a slow PC? Try a Free scan
http://www.spamfighter.com/SLOW-PCfighter?cid=sigen

In response to

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Craig Ringer 2014-06-20 13:24:42 Re: Protocol de-synchronisation bug, bogus query sent
Previous Message Craig Ringer 2014-06-20 01:55:31 Re: Protocol de-synchronisation bug, bogus query sent