Re: Protocol de-synchronisation bug, bogus query sent

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
Cc: "pgsql-odbc(at)postgresql(dot)org" <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: Protocol de-synchronisation bug, bogus query sent
Date: 2014-06-20 01:55:31
Message-ID: 53A39493.5030104@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

On 06/20/2014 08:29 AM, Craig Ringer wrote:
> On 06/19/2014 08:08 PM, Hiroshi Inoue wrote:
>> (2014/06/19 11:47), Craig Ringer wrote:
>>> On 06/19/2014 12:56 PM, Craig Ringer wrote:
>>>>
>>>> and we're attempting to use the version obtained from the server before
>>>> we have it, instead of the conninfo-specified version to use for
>>>> protocol selection purposes.
>>>
>>> The attached patch fixes this.
>>
>> Thanks.
>> I would also check the source of this trouble.
>
> Huh?
>
> That _is_ the source of this trouble. Some code that runs during
> connection setup, before the server version is available, tries to use
> the version obtained from the server instead of the protocol version
> requested in the conninfo.

Just to clarify, only the 0002 patch is required. My branch at:

https://github.com/ringerc/psqlodbc/tree/fix-febe-protocol-desync-emptyquery

only contains the second patch. I've attached a revised version that
should make that clearer.

Please apply / pull.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Fix-use-of-server-queried-version-before-connection.patch text/x-patch 1.8 KB

In response to

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Inoue, Hiroshi 2014-06-20 03:27:28 Re: Protocol de-synchronisation bug, bogus query sent
Previous Message Michael Paquier 2014-06-20 00:30:56 Re: Removing support for v1 and v2 protocols?