| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [18] Unintentional behavior change in commit e9931bfb75 |
| Date: | 2025-04-15 23:08:55 |
| Message-ID: | 5393ccd73d99ea80f03a6477dbacc476483da979.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2025-04-14 at 13:44 -0700, Noah Misch wrote:
> v18 regc_pg_locale.c uses only the locale_t-extended forms, and it
> aims not to
> depend on LC_CTYPE. v17 used both tolower() and tolower_l(), but v18
> uses the
> latter only.
Fixed in v2-0001 by rewording the comment slightly.
>
> However, I think v17's
> concept of separate PG_REGEX_ symbols for the default-locale case is
> still the
> right thing for v18. In other words, this code should change to look
> more
> like v17, with the removal of non-locale_t calls being the main
> change.
I tried that in v2-0003, but I think it ended up worse. Most
pg_wc_xyz() functions don't care if it's the default collation or not,
so there are a lot of duplicate cases.
The previous approach is still there as v2-0002.
Regrads,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Improve-comment-in-regc_pg_locale.c.patch | text/x-patch | 3.4 KB |
| v2-0002-Another-unintentional-behavior-change-in-commit-e.patch | text/x-patch | 2.2 KB |
| v2-0003-alternative-approach.patch | text/x-patch | 9.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-04-15 23:19:42 | Re: Built-in Raft replication |
| Previous Message | Tom Lane | 2025-04-15 22:51:55 | Re: pg_dump --if-exists --clean when drop index that is partition of a partitioned index |