Re: pg_control is missing a field for LOBLKSIZE

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: pg_control is missing a field for LOBLKSIZE
Date: 2014-06-04 14:25:07
Message-ID: 538F2C43.3040506@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 06/04/2014 10:03 AM, Tom Lane wrote:
> I just chanced to notice that if someone were to change the value for
> LOBLKSIZE and recompile, there'd be nothing to stop him from starting
> that postmaster against an existing database, even though it would
> completely misinterpret and mangle any data in pg_largeobject.
>
> I think there ought to be a guard for that, for exactly the same reasons
> that we check TOAST_MAX_CHUNK_SIZE: correct interpretation of on-disk
> data requires that this value match the original database configuration.
>
> Obviously it's too late to do anything about this in existing branches,
> but I propose to add a field to pg_control after we branch off 9.4.
>
>

If we did an initdb-requiring change for 9.4 could we piggy-back this
onto it?

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-06-04 14:26:23 Re: pass Form_pg_attribute to examine_attribute rather than Relation structure.
Previous Message Tom Lane 2014-06-04 14:14:42 Re: Allowing join removals for more join types