pg_control is missing a field for LOBLKSIZE

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: pg_control is missing a field for LOBLKSIZE
Date: 2014-06-04 14:03:09
Message-ID: 19076.1401890589@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I just chanced to notice that if someone were to change the value for
LOBLKSIZE and recompile, there'd be nothing to stop him from starting
that postmaster against an existing database, even though it would
completely misinterpret and mangle any data in pg_largeobject.

I think there ought to be a guard for that, for exactly the same reasons
that we check TOAST_MAX_CHUNK_SIZE: correct interpretation of on-disk
data requires that this value match the original database configuration.

Obviously it's too late to do anything about this in existing branches,
but I propose to add a field to pg_control after we branch off 9.4.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2014-06-04 14:10:48 Re: Need to backpatch 2985e16 to 9.3 and further (HS regression test out)
Previous Message Andres Freund 2014-06-04 13:56:57 Re: Proposing pg_hibernate