| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: btree_gist macaddr valgrind woes |
| Date: | 2014-05-16 14:08:40 |
| Message-ID: | 53761BE8.6070209@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05/16/2014 01:28 PM, Andres Freund wrote:
> Hi,
>
> After Heikki has fixed the bit btree_gist bugs my valgrind run shows a
> bug in macaddr.
>
> Presumably it's because the type is a fixed width type with a length of
> 6. I guess it's allocating stuff sizeof(macaddr) but then passes the
> result around as a Datum which doesn't work well.
The complaints seem to be coming from all the varlen data types, too,
not just macaddr:
> ...
> ==14219== by 0x6B74BF1: gbt_macad_compress (btree_macaddr.c:113)
> ...
> ==14250== by 0x6B75C45: gbt_text_picksplit (btree_text.c:215)
> ...
> ==14280== by 0x6B76063: gbt_bytea_picksplit (btree_bytea.c:143)
> ...
> ==14292== by 0x6B76591: gbt_bit_union (btree_bit.c:173)
> ...
I'm not seeing those valgrind warnings when I run it. Can you give more
details on how to reproduce?
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-05-16 14:13:29 | Re: btree_gist macaddr valgrind woes |
| Previous Message | Craig Ringer | 2014-05-16 13:21:25 | Re: SKIP LOCKED DATA (work in progress) |