Re: btree_gist macaddr valgrind woes

On 2014-05-16 17:08:40 +0300, Heikki Linnakangas wrote:
> On 05/16/2014 01:28 PM, Andres Freund wrote:
> >Hi,
> >
> >After Heikki has fixed the bit btree_gist bugs my valgrind run shows a
> >bug in macaddr.
> >
> >Presumably it's because the type is a fixed width type with a length of
> >6. I guess it's allocating stuff sizeof(macaddr) but then passes the
> >result around as a Datum which doesn't work well.
>
> The complaints seem to be coming from all the varlen data types, too, not
> just macaddr:

Hm, right. Didn't look very far yet.

> >...
> >==14219== by 0x6B74BF1: gbt_macad_compress (btree_macaddr.c:113)
> >...
> >==14250== by 0x6B75C45: gbt_text_picksplit (btree_text.c:215)
> >...
> >==14280== by 0x6B76063: gbt_bytea_picksplit (btree_bytea.c:143)
> >...
> >==14292== by 0x6B76591: gbt_bit_union (btree_bit.c:173)
> >...
>
> I'm not seeing those valgrind warnings when I run it. Can you give more
> details on how to reproduce?

I've added a bit more support for valgrind, but I don't see that being
relevant in those. Are you compiling with USE_VALGRIND?

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services