Re: New timezones used in regression tests

From: Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christoph Berg <cb(at)df7cb(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: New timezones used in regression tests
Date: 2014-05-12 23:23:49
Message-ID: 53715805.9000302@archidevsys.co.nz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13/05/14 11:16, Tom Lane wrote:
> Christoph Berg <cb(at)df7cb(dot)de> writes:
>> 84df54b22e8035addc7108abd9ff6995e8c49264 introduced timestamp
>> constructors. In the regression tests, various time zones are tested,
>> including America/Metlakatla. Now, if you configure using
>> --with-system-tzdata, you'll get an error if that zone isn't there.
>> Unfortunately, this is what I'm getting now when trying to build beta1
>> on Ubuntu 10.04 (lucid) with tzdata 2010i-1:
> I agree, that seems an entirely gratuitous choice of zone. It does
> seem like a good idea to test a zone that has a nonintegral offset
> from GMT, but we can get that from almost anywhere as long as we're
> testing a pre-1900 date. There's no need to use any zones that aren't
> long-established and unlikely to change.
>
> I'm quite unimpressed by the dependency on Mars/Mons_Olympus, too ... that
> might not fail *today*, but considering it's a real location, assuming it
> is not in the IANA database seems like a recipe for future failure.
> Maybe something like Nehwon/Lankhmar? Or maybe we should not try to be
> cute but just test Foo/Bar.
>
> regards, tom lane
>
>
You might like to consider the Chatham Islands, they are offset by 45
minutes:
(GMT +12:45 / GMT +13:45)!

Cheers,
Gavin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-05-12 23:32:51 Re: pgsql: Revive line type
Previous Message Bruce Momjian 2014-05-12 23:21:21 Re: pgsql: Revive line type