From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Revive line type |
Date: | 2014-05-12 23:21:21 |
Message-ID: | 20140512232121.GB16042@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Mon, May 5, 2014 at 01:24:15PM -0400, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > On 2013-10-10 02:43:20 +0000, Peter Eisentraut wrote:
> >> Revive line type
>
> > That commit missed to update pg_type.h to the changed length of the line
> > type. Patch attached.
>
> Ouch. Good thing we caught this now.
>
> In principle, fixing this breaks pg_upgrade'ability for anyone who was
> using the line type before (presumably by compiling with
> -DENABLE_LINE_TYPE). However, we're breaking things for them anyway by
> changing the text representation, so that's probably not worth worrying
> over.
Should this be listed in the 9.4 release notes? We didn't have _any_
line type before unless you -D/enabled it? Our release notes say:
Fully-implement the <link
linkend="datatype-line"><type>line</></link> data type (Peter
Eisentraut)
Is this text misleading?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-05-12 23:32:51 | Re: pgsql: Revive line type |
Previous Message | Michael Paquier | 2014-05-12 23:19:22 | Re: pgsql: Replace SYSTEMQUOTEs with Windows-specific wrapper functions. |
From | Date | Subject | |
---|---|---|---|
Next Message | Gavin Flower | 2014-05-12 23:23:49 | Re: New timezones used in regression tests |
Previous Message | Tom Lane | 2014-05-12 23:16:48 | Re: New timezones used in regression tests |