Re: pgsql: Attempt to get plpython regression tests working again for MSVC

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Attempt to get plpython regression tests working again for MSVC
Date: 2014-04-16 18:50:44
Message-ID: 534ED104.2030409@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 04/16/2014 02:00 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Attempt to get plpython regression tests working again for MSVC builds.
>> This has probably been broken for quite a long time. Buildfarm member
>> currawong's current results suggest that it's been broken since 9.1, so
>> backpatch this to that branch.
> While not objecting to the patch itself, I don't understand this commit
> message. I see no recent buildfarm results suggesting that currawong
> (or indeed any other MSVC critter) is unhappy with plpython.
>
>

The reason it's not unhappy is that it's not running the plpython tests
at all, because it's testing for the wrong directory's existence. This
is meant to rectify that.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2014-04-16 19:07:00 pgsql: docs: make max_wal_senders higher to handle disconnects
Previous Message Tom Lane 2014-04-16 18:29:11 pgsql: Update oidjoins regression test for 9.4.