Re: pgsql: Attempt to get plpython regression tests working again for MSVC

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Attempt to get plpython regression tests working again for MSVC
Date: 2014-04-16 19:17:56
Message-ID: 12005.1397675876@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 04/16/2014 02:00 PM, Tom Lane wrote:
>> While not objecting to the patch itself, I don't understand this commit
>> message. I see no recent buildfarm results suggesting that currawong
>> (or indeed any other MSVC critter) is unhappy with plpython.

> The reason it's not unhappy is that it's not running the plpython tests
> at all, because it's testing for the wrong directory's existence. This
> is meant to rectify that.

Ah, understood. The commit message could've been clearer about that.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-04-16 21:22:09 pgsql: Fix contrib/postgres_fdw's remote-estimate representation of arr
Previous Message Bruce Momjian 2014-04-16 19:07:00 pgsql: docs: make max_wal_senders higher to handle disconnects