Re: pgsql: Revert "Secure Unix-domain sockets of "make check" temporary clu

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Noah Misch <noah(at)leadboat(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Revert "Secure Unix-domain sockets of "make check" temporary clu
Date: 2014-03-29 22:10:57
Message-ID: 533744F1.4090601@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 03/29/2014 05:39 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> On 03/29/2014 04:47 PM, Tom Lane wrote:
>>> In this particular example the path is only about 7 characters too long,
>>> but I suppose trying to shave off a few characters isn't really going
>>> to be a robust solution.
>> Since you have one of the offending buildfarm machines (dromedary) why
>> not try this: in the build_env section of the config file, add
>> PG_REGRESS_SOCK_DIR => "/Users/buildfarm/bf-data/$branch/",
> I'm happy to tweak the config, but given that Noah reverted the patch,
> what is it that we're testing exactly?
>
>

Oh, the commit emails arrived in my mailbox after the reversion emails,
so I thought he'd reapplied the patch. Never mind.

I can rig up a test with a long path and test with and without the patch.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-03-29 22:18:21 Re: pgsql: Revert "Secure Unix-domain sockets of "make check" temporary clu
Previous Message Tom Lane 2014-03-29 21:39:11 Re: pgsql: Revert "Secure Unix-domain sockets of "make check" temporary clu

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2014-03-29 22:13:51 Re: psql \d+ and oid display
Previous Message Bruce Momjian 2014-03-29 22:10:00 Re: psql \d+ and oid display