| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions. |
| Date: | 2014-03-21 22:30:36 |
| Message-ID: | 532CBD8C.9010801@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 03/21/2014 10:58 PM, Tom Lane wrote:
> I wrote:
>> I think the whole thing is too cute by half. Why isn't it just
>
>> typedef enum GinLogicValue
>> {
>> GIN_FALSE = 0, /* item is present / matches */
>> GIN_TRUE = 1, /* item is not present / does not match */
>> GIN_MAYBE = 2 /* don't know if item is present / don't know if
>> * matches */
>> } GinLogicValue;
>
> ... and now that I look at it a second time: *please* tell me the comments
> on the first two values should be swapped. The API isn't really "false
> means a match", is it?
*facepalm*. Yes, the comments are backwards...
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-03-21 22:33:10 | pgsql: Fix build with LWLOCK_STATS or dtrace. |
| Previous Message | Tom Lane | 2014-03-21 21:58:17 | Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions. |