Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions.
Date: 2014-03-21 21:58:17
Message-ID: 26924.1395439097@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

I wrote:
> I think the whole thing is too cute by half. Why isn't it just

> typedef enum GinLogicValue
> {
> GIN_FALSE = 0, /* item is present / matches */
> GIN_TRUE = 1, /* item is not present / does not match */
> GIN_MAYBE = 2 /* don't know if item is present / don't know if
> * matches */
> } GinLogicValue;

... and now that I look at it a second time: *please* tell me the comments
on the first two values should be swapped. The API isn't really "false
means a match", is it?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-03-21 22:30:36 Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions.
Previous Message Andres Freund 2014-03-21 21:47:48 Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions.