Re: Performance improvement proposal. Removal of toLowerCase calls. PR

Dave,
Having merged in your change on master the compilation error is fixed.
The testsuite is passing for the three different jdk specs.

For those interested to know the matching with combinations of case
possible take a look at the test cases covering the proposed behaviour.

https://github.com/whitingjr/pgjdbc/blob/remove-toLowerCase-calls/org/postgresql/test/jdbc2/ColumnSanitiserDisabledTest.java?#L66

Jeremy

On 22/01/14 21:08, Jeremy Whiting wrote:
> Hi Dave,
> It's not tests that fail but compilation errors.
>
> The compile phase output is attached to an email in a new thread I
> started earlier. Subject is "Master branch compile error using 1.5 spec.".
>
> Jeremy
>
> On 22/01/14 19:38, Dave Cramer wrote:
>> Hi Jeremy,
>>
>> I saw the PR. Thanks
>>
>> What tests fail in 1.5 ?
>>
>> Dave Cramer
>>
>> dave.cramer(at)credativ(dot)ca
>> http://www.credativ.ca
>>