Re: Master branch compile error using 1.5 spec.

Hi Dave,
Sorry, my mistake, JAVA_HOME was not correctly set.

All the compile errors I saw have been fixed by your PR.

Jeremy

On 31/01/14 13:28, Dave Cramer wrote:
> Hmmm that's very odd.
>
> I'll check my build environment again
>
> Dave Cramer
>
> dave.cramer(at)credativ(dot)ca
> http://www.credativ.ca
>
>
> On Fri, Jan 31, 2014 at 7:15 AM, Jeremy Whiting <jwhiting(at)redhat(dot)com
> <mailto:jwhiting(at)redhat(dot)com>> wrote:
>
> Dave,
> Yes, using one of those.
>
> $ java -version
> java version "1.5.0_22"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_22-b03)
> Java HotSpot(TM) 64-Bit Server VM (build 1.5.0_22-b03, mixed mode)
>
> Jeremy
>
>
> On 30/01/14 17:19, Dave Cramer wrote:
>> Jeremy,
>>
>> I think you have to actually use a 1.5 jdk as opposed to just
>> specifying the version on the ant command
>>
>> Dave
>>
>> Dave Cramer
>>
>> dave.cramer(at)credativ(dot)ca
>> http://www.credativ.ca
>>
>>
>> On Thu, Jan 30, 2014 at 12:13 PM, Jeremy Whiting
>> <jwhiting(at)redhat(dot)com <mailto:jwhiting(at)redhat(dot)com>> wrote:
>>
>> Hi Dave,
>> I pulled in your fix for the 1.5 error. I must be using the
>> wrong command line params as I still see 18 errors. This is
>> now using a 1.5 JDK (build 1.5.0_22-b03). How are you
>> executing the tests ?
>>
>> Regards,
>> Jeremy
>>
>>
>> On 24/01/14 15:38, Dave Cramer wrote:
>>> Jeremy,
>>>
>>> I think you actually need to use a 1.5 jvm to get this to
>>> compile. I have a machine that does this and there is one
>>> error which is easily fixable. ResultSet.isClosed does not
>>> exist in 1.5
>>>
>>>
>>>
>>> Dave Cramer
>>>
>>> dave.cramer(at)credativ(dot)ca
>>> http://www.credativ.ca
>>>
>>>
>>> On Wed, Jan 22, 2014 at 6:04 AM, Jeremy Whiting
>>> <jwhiting(at)redhat(dot)com <mailto:jwhiting(at)redhat(dot)com>> wrote:
>>>
>>> Hi,
>>> Just to report I am getting a compile error on master
>>> branch. Using
>>> this combination of command line arguments.
>>>
>>> $ ant -Djava.specification.version=1.5 clean compile
>>> ....
>>> [javac] 18 errors
>>> [javac] 1 warning
>>>
>>> The full list of compilation errors are in the attached
>>> file.
>>>
>>> Shall I create an issue on GitHub to track this ?
>>>
>>> Regards,
>>> Jeremy
>>>
>>>
>>> $ java -version
>>> java version "1.7.0_51"
>>> OpenJDK Runtime Environment (fedora-2.4.4.0.fc19-x86_64
>>> u51-b02)
>>> OpenJDK 64-Bit Server VM (build 24.45-b08, mixed mode)
>>> $ ant -version
>>> Apache Ant(TM) version 1.9.2 compiled on July 8 2013
>>> $ uname -a
>>> Linux f19lite 3.12.8-200.fc19.x86_64 #1 SMP Thu Jan 16
>>> 04:18:11 UTC 2014
>>> x86_64 x86_64 x86_64 GNU/Linux
>>>
>>>
>>> --
>>> Sent via pgsql-jdbc mailing list
>>> (pgsql-jdbc(at)postgresql(dot)org
>>> <mailto:pgsql-jdbc(at)postgresql(dot)org>)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgsql-jdbc
>>>
>>>
>>
>>
>
>