| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <stark(at)mit(dot)edu>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Planning time in explain/explain analyze |
| Date: | 2014-01-27 17:35:06 |
| Message-ID: | 52E698CA.8070706@proxel.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/13/2014 09:48 PM, Robert Haas wrote:
> What I'm saying is that if EXPLAIN reports something that's labelled
> "Planning Time", it should *be* the planning time, and not anything
> else. When we retrieve a plan from cache, it would be sensible not to
> report the planning time at all, and IMHO it would also be sensible to
> report the time it actually took to plan whenever we originally did
> it. But reporting a value that is not the planning time and calling
> it the planning time does not seem like a good idea to me.
Here is a patch which only prints when "Planning time" when a prepared
statment actually planned a query. I do not really like how I check for
if it was replanned, but I tried to avoid making changes in plancache.c.
Does this idea look ok?
--
Andreas Karlsson
| Attachment | Content-Type | Size |
|---|---|---|
| explainplantime-v4.diff | text/x-patch | 16.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ronan Dunklau | 2014-01-27 17:35:43 | Re: [bug fix] "pg_ctl stop" times out when it should respond quickly |
| Previous Message | Tom Lane | 2014-01-27 17:25:42 | Re: Fwd: Request for error explaination || Adding a new integer in indextupleData Structure |