| From: | Ronan Dunklau <ronan(dot)dunklau(at)dalibo(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, MauMau <maumau307(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [bug fix] "pg_ctl stop" times out when it should respond quickly |
| Date: | 2014-01-27 17:35:43 |
| Message-ID: | 2243350.MezRAmTkfY@ronan.dunklau.fr |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Le mardi 7 janvier 2014 17:05:03 Michael Paquier a écrit :
> On Sun, Jan 5, 2014 at 3:49 PM, MauMau <maumau307(at)gmail(dot)com> wrote:
> > Could you confirm again and tell me what problem is happening?
>
> FWIW, I just quickly tested those two patches independently and got
> them correctly applied with patch -p1 < $PATCH on master at edc4345.
> They compiled and passed as well make check.
> Regards,
Both patches apply cleanly, I'll focus on the pg_stop_fail_v3 patch.
Tests are running correctly.
The bug this patch is supposed to fix has been reproduced on current HEAD, and
cannot be reproduced using the patch.
Previous concerns about using both get_pgpid and postmaster_is_alive are
adressed.
There is no regression tests covering this bugfix, althought I don't know if
it would be practical to implement them.
--
Ronan Dunklau
http://dalibo.com - http://dalibo.org
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2014-01-27 17:36:10 | Re: A better way than tweaking NTUP_PER_BUCKET |
| Previous Message | Andreas Karlsson | 2014-01-27 17:35:06 | Re: Planning time in explain/explain analyze |