Re: [PATCH] pg_basebackup: progress report max once per second

From: Oskari Saarenmaa <os(at)ohmu(dot)fi>
To: Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, Mika Eloranta <mel(at)ohmu(dot)fi>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] pg_basebackup: progress report max once per second
Date: 2014-01-20 22:17:05
Message-ID: 52DDA061.1050404@ohmu.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

18.11.2013 07:53, Sawada Masahiko kirjoitti:
>> On 13 Nov 2013, at 20:51, Mika Eloranta <mel(at)ohmu(dot)fi> wrote:
>>> Prevent excessive progress reporting that can grow to gigabytes
>>> of output with large databases.
>
> I got error with following scenario.
>
> $ initdb -D data -E UTF8 --no-locale
> /* setting the replication parameters */
> $ pg_basebackup -D 2data
> Floating point exception
> LOG: could not send data to client: Broken pipe
> ERROR: base backup could not send data, aborting backup
> FATAL: connection to client lost

Attached a rebased patch with a fix for division by zero error plus some
code style issues. I also moved the patch to the current commitfest.

/ Oskari

Attachment Content-Type Size
0001-pg_basebackup-progress-report-max-once-per-second.patch text/x-diff 3.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2014-01-20 22:56:59 Re: Closing commitfest 2013-11
Previous Message Alvaro Herrera 2014-01-20 21:49:21 Re: Fix memset usage in pgcrypto