Re: [GENERAL] pg_upgrade & tablespaces

On 01/12/2014 08:04 PM, Bruce Momjian wrote:
> On Sun, Jan 12, 2014 at 07:58:52PM -0800, Adrian Klaver wrote:
>> Well the problem is that it actually points to a current PGDATA just
>> the wrong one. To use the source installation path and the suggested
>> upgrade method from pg_upgrade.
>>

>> In the pgsql_old installation you have symlinks pointing back to the
>> current default location. As well pg_tablespace points back to
>> /usr/local/pgsql/data/ The issue is that there is not actually
>> anything there in the way of a tablespace. So when pg_upgrade runs
>> it tries to upgrade from /usr/local/pgsql/data/tblspc_dir to
>> /usr/local/pgsql/data/tblspc_dir where the first directory either
>> does not exist. or if the user went ahead and created the directory
>> in the new installation, is empty. What is really wanted is to
>> upgrade from /usr/local/pgsql_old/data/tblspc_dir to
>> /usr/local/pgsql/data/tblspc_dir. Right now the only way that
>> happens is with user intervention.
>
> Right, it points to _nothing_ in the _new_ cluster. Perhaps the
> simplest approach would be to check all the pg_tablespace locations to
> see if they point at real directories. If not, we would have to have
> the user update pg_tablespace and the symlinks. :-( Actually, even in
> 9.2+, those symlinks are going to point at the same "nothing". That
> would support checking the symlinks in all versions.
>

Agreed.

--
Adrian Klaver
adrian(dot)klaver(at)gmail(dot)com