Re: Domains as Subtypes

From: Jim Nasby <jnasby(at)pervasive(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: josh(at)agliodbs(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Domains as Subtypes
Date: 2006-03-25 18:16:13
Message-ID: 52C4EF13-1027-498E-9FC7-D33583833CEA@pervasive.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mar 25, 2006, at 4:14 PM, Tom Lane wrote:

> "Jim C. Nasby" <jnasby(at)pervasive(dot)com> writes:
>> On Fri, Mar 24, 2006 at 10:49:00PM -0500, Tom Lane wrote:
>>> I think we've got that one actually. It's domains as PL-function
>>> output
>>> types that aren't checked. Also plpgsql fails to enforce domain
>>> checks
>>> on its local variables.
>
>> So is this the complete list?
>
> No, I don't think so. IIRC we're also missing domain checks on
> parameter values in Bind messages, and there might be some other
> holes too. See the archives.
>
> I made a suggestion about closing all these holes at once by
> integrating domain checking into the I/O functions for domains,
> but it's not clear how to do that without a big performance hit.

Performance hit on just domain handling or overall? Personally, I'd
rather see a hit on domain handling that we can work on later rather
than the current state of things which seems to smack of MySQL (Get
the feature 'checked off the list' first, then worry about doing it
the right way).
--
Jim C. Nasby, Sr. Engineering Consultant jnasby(at)pervasive(dot)com
Pervasive Software http://pervasive.com work: 512-231-6117
vcard: http://jim.nasby.net/pervasive.vcf cell: 512-569-9461

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2006-03-25 19:21:50 Re: 8.2 planning features
Previous Message Josh Berkus 2006-03-25 18:00:54 Re: A big thank you to all!