Re: Commitfest II CLosed

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Commitfest II CLosed
Date: 2013-10-21 17:33:38
Message-ID: 52656572.7060100@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres,

> I find it utterly ridiculous to accuse the people that *do* reviews of
> not doing anything. By doing code-level reviews reviewers teach authors
> and bystanders more about the code. Which actually can increase the
> number of review(ers) and even committers in the long run.

It would be nice if it worked that way -- in a review system which
wasn't broken, it *should* work that way -- but a quick look at who's
been doing the reviews for the last 2 releases shows that we no longer
get new reviewers.

Don't get me wrong. *you* are doing a ton of reviews, and if we had 20
people like you, then we wouldn't be talking about the review process at
all because everything would be done already. But we don't. And, for
that matter, I personally would love to see you not *need* to do so many
reviews, so that you could spend more time working on LSR.

> And no, not having an own solution, doesn't turn somebody elses
> non-solution into a solution.

Either you're proposing a solution, supporting someone else's solution,
or you're saying the problem isn't important. There is no fourth
alternative.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2013-10-21 17:35:33 Re: [HACKERS] Who is pgFoundery administrator?
Previous Message Boszormenyi Zoltan 2013-10-21 17:28:37 Re: Commitfest II CLosed