| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | cedric(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org, Josh Berkus <josh(at)agliodbs(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Subject: | Re: Bugfix and new feature for PGXS |
| Date: | 2013-10-08 14:04:28 |
| Message-ID: | 525410EC.9010002@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/07/2013 08:47 PM, Peter Eisentraut wrote:
>
> I suspect this line
>
> submake-libpq: $(libdir)/libpq.so ;
>
> will cause problems on platforms with a different extension (e.g. OS X).
suggested fix is below.
cheers
andrew
diff --git a/src/Makefile.global.in b/src/Makefile.global.in
index bb732bb..b562378 100644
--- a/src/Makefile.global.in
+++ b/src/Makefile.global.in
@@ -422,7 +422,11 @@ ifndef PGXS
submake-libpq:
$(MAKE) -C $(libpq_builddir) all
else
-submake-libpq: $(libdir)/libpq.so ;
+ifneq ($(PORTNAME),cygwin)
+submake-libpq: $(libdir)/libpq$(DLSUFFIX) ;
+else
+submake-libpq: $(libdir)/cygpq$(DLSUFFIX) ;
+endif
endif
ifndef PGXS
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2013-10-08 14:26:26 | Release note fix for timeline item |
| Previous Message | David Johnston | 2013-10-08 13:27:51 | Re: Urgent Help Required |