| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | cedric(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org, Josh Berkus <josh(at)agliodbs(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Subject: | Re: Bugfix and new feature for PGXS |
| Date: | 2013-10-11 01:35:07 |
| Message-ID: | 1381455307.5264.14.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2013-10-08 at 10:04 -0400, Andrew Dunstan wrote:
> On 10/07/2013 08:47 PM, Peter Eisentraut wrote:
> >
> > I suspect this line
> >
> > submake-libpq: $(libdir)/libpq.so ;
> >
> > will cause problems on platforms with a different extension (e.g. OS X).
>
>
> suggested fix is below.
Hmm, this would duplicate information about shared library naming in a
place outside of Makefile.shlib. That doesn't look right.
> diff --git a/src/Makefile.global.in b/src/Makefile.global.in
> index bb732bb..b562378 100644
> --- a/src/Makefile.global.in
> +++ b/src/Makefile.global.in
> @@ -422,7 +422,11 @@ ifndef PGXS
> submake-libpq:
> $(MAKE) -C $(libpq_builddir) all
> else
> -submake-libpq: $(libdir)/libpq.so ;
> +ifneq ($(PORTNAME),cygwin)
> +submake-libpq: $(libdir)/libpq$(DLSUFFIX) ;
> +else
> +submake-libpq: $(libdir)/cygpq$(DLSUFFIX) ;
> +endif
> endif
>
> ifndef PGXS
>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2013-10-11 01:37:24 | Re: Bugfix and new feature for PGXS |
| Previous Message | Peter Eisentraut | 2013-10-11 01:09:26 | Re: GIN improvements part 1: additional information |