Re: missing SSI check in heapgettup_pagemode() ?

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Kevin Grittner <kgrittn(at)ymail(dot)com>, Dan Ports <drkp(at)csail(dot)mit(dot)edu>
Subject: Re: missing SSI check in heapgettup_pagemode() ?
Date: 2013-09-05 17:45:46
Message-ID: 5228C34A.5010807@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05.09.2013 20:30, Alvaro Herrera wrote:
> I was scrolling heapgettup() and heapgettup_pagemode() in parallel, and
> noticed that the former calls CheckForSerializableConflictOut() for
> tuples read, and the latter doesn't. Is there a reason for this
> discrepancy? If so, I think it warrants a comment about the missing
> check.

In page-at-a-time mode, the CheckForSerializableConflictOut() is done in
heapgetpage(). Same with the visibility checks.

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2013-09-05 17:56:14 Re: missing SSI check in heapgettup_pagemode() ?
Previous Message Jeff Janes 2013-09-05 17:41:25 Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric?