Re: missing SSI check in heapgettup_pagemode() ?

From: Kevin Grittner <kgrittn(at)ymail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Dan Ports <drkp(at)csail(dot)mit(dot)edu>
Subject: Re: missing SSI check in heapgettup_pagemode() ?
Date: 2013-09-05 17:56:14
Message-ID: 1378403774.52392.YahooMailNeo@web162904.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:

> I was scrolling heapgettup() and heapgettup_pagemode() in parallel, and
> noticed that the former calls CheckForSerializableConflictOut() for
> tuples read, and the latter doesn't.  Is there a reason for this
> discrepancy?  If so, I think it warrants a comment about the missing
> check.

That is covered in heapgetpage().

Do you want to offer a patch to add a comment to that effect, or
would you prefer that I do?

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-09-05 18:14:39 Re: strange IS NULL behaviour
Previous Message Heikki Linnakangas 2013-09-05 17:45:46 Re: missing SSI check in heapgettup_pagemode() ?