Re: Add regression tests for COLLATE

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robins Tharakan <tharakan(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add regression tests for COLLATE
Date: 2013-07-06 13:27:53
Message-ID: 51D81B59.3040200@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 07/06/2013 09:12 AM, Robert Haas wrote:
> On Fri, Jul 5, 2013 at 6:56 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> On 2013-07-03 14:17:20 -0400, Robert Haas wrote:
>>> I agree. I think it'd be a good idea to get the buildfarm to run the
>>> existing collate.utf8.linux test regularly on platforms where it
>>> passes, but this particular approach is valuable mostly because
>>> (supposedly) it was going to work everywhere. However, it doesn't.
>> Hm. What about extending the existing resultmap logic to make that
>> possible in general? E.g. don't run the test if a file is mapped to an
>> empty expected file.
> Not a bad thought.
>

Or maybe just invent a magic result file name such as "none" or
"do_not_run".

I'm not keen to have us build up a large patchwork of regression tests
that run on some platforms and not on others, though.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-07-06 14:33:05 Run-time posix_fallocate failures
Previous Message Robert Haas 2013-07-06 13:12:15 Re: Add regression tests for COLLATE