Re: [pgadmin-hackers] Remove dialogue "Apply" buttons?

From: Michal Kozusznik <kozusznik(dot)michal(at)ifortuna(dot)cz>
To: <pgadmin-support(at)postgresql(dot)org>
Subject: Re: [pgadmin-hackers] Remove dialogue "Apply" buttons?
Date: 2013-05-20 09:32:37
Message-ID: 5199EDB5.5080402@ifortuna.cz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers pgadmin-support

On 18.5.2013 15:26, Dave Page wrote:
>
> As we have so few of these buttons and they're there primarily to
> support a working practice that we discourage anyway, I'd like to
> simply remove them so we can avoid the fragile and messy code changes
> needed to make them work reliably.
>
> I propose to do this both for 1.18.x *and* 1.16.2+
>
> Comments/objections please?

Do I understand correctly, you are talking about Apply button available
in function edit window?
If yes, how do you suppose to work, editing function content without
Apply button? Using OK button only? but OK button closes window, so
making multiple changes needs to reopen this windows again and again. If
I'm right, then drop editing function content at at all. Seems to be
useless then.

> Well, no it's not - that's the point. There is very high risk that
> fixing the bugs will cause even more things to break, and frankly I'm
> not prepared to spend any more time fixing them. My beermat
> calculation tells me we've already spent at least 2 man-weeks in this
> cycle alone, trying to fix issues caused by these buttons.

I'm aghast about the source code quality. Fixing Apply buttons took 2
man-weeks?
Let's take it half-seriously: maybe it's not bad idea to drop pgadmin
developement at all ;-) At least consider to rewrite it from screatch.

With regards

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2013-05-20 09:48:50 Re: [pgadmin-hackers] Remove dialogue "Apply" buttons?
Previous Message Dinesh Kumar 2013-05-19 15:37:45 Re: [pgadmin-hackers] Browser fixes

Browse pgadmin-support by date

  From Date Subject
Next Message Dave Page 2013-05-20 09:48:50 Re: [pgadmin-hackers] Remove dialogue "Apply" buttons?
Previous Message Gabriele Franch 2013-05-20 09:06:35 Column comments not shown on 1.18.0 alpha1