From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: missing time.h include in psql/command.c since the addition of \watch |
Date: | 2013-04-24 16:16:21 |
Message-ID: | 51780555.9040301@vmware.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 24.04.2013 16:27, Andres Freund wrote:
> Hi,
>
> our internal testbuilds show a new warning on windows:
> src\bin\psql\command.c(2617): warning C4013: 'time' undefined; assuming extern returning int [C:\jenkins\workspace\andres_git.postgresql.org_windows\BT\release\SL_OS\windows\TA\x86\TO\xp\psql.vcxproj]
> src\bin\psql\command.c(2619): warning C4013: 'asctime' undefined; assuming extern returning int [C:\jenkins\workspace\andres_git.postgresql.org_windows\BT\release\SL_OS\windows\TA\x86\TO\xp\psql.vcxproj]
> src\bin\psql\command.c(2619): warning C4013: 'localtime' undefined; assuming extern returning int [C:\jenkins\workspace\andres_git.postgresql.org_windows\BT\release\SL_OS\windows\TA\x86\TO\xp\psql.vcxproj]
>
> Looking at command.c its neither surprising that we get that warning,
> nor that we don't get it on non-windows builds. Those get time.h via
> portability/instr_time.h.
>
> So it seems we should add a time.h include to command.c. Trivial patch
> for that attached.
Thanks, applied.
- Heikki
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2013-04-24 16:30:57 | Re: putting a bgworker to rest |
Previous Message | Andres Freund | 2013-04-24 14:18:11 | Re: high io BUT huge amount of free memory |