missing time.h include in psql/command.c since the addition of \watch

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: missing time.h include in psql/command.c since the addition of \watch
Date: 2013-04-24 13:27:43
Message-ID: 20130424132743.GD4536@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

our internal testbuilds show a new warning on windows:
src\bin\psql\command.c(2617): warning C4013: 'time' undefined; assuming extern returning int [C:\jenkins\workspace\andres_git.postgresql.org_windows\BT\release\SL_OS\windows\TA\x86\TO\xp\psql.vcxproj]
src\bin\psql\command.c(2619): warning C4013: 'asctime' undefined; assuming extern returning int [C:\jenkins\workspace\andres_git.postgresql.org_windows\BT\release\SL_OS\windows\TA\x86\TO\xp\psql.vcxproj]
src\bin\psql\command.c(2619): warning C4013: 'localtime' undefined; assuming extern returning int [C:\jenkins\workspace\andres_git.postgresql.org_windows\BT\release\SL_OS\windows\TA\x86\TO\xp\psql.vcxproj]

Looking at command.c its neither surprising that we get that warning,
nor that we don't get it on non-windows builds. Those get time.h via
portability/instr_time.h.

So it seems we should add a time.h include to command.c. Trivial patch
for that attached.

Not sure why that warning isn't visible on the buildfarm though...

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
add-time-h-to-psql-command-c.patch text/x-patch 263 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-04-24 13:30:36 Re: 9.3 release notes suggestions
Previous Message Robert Haas 2013-04-24 13:24:50 Re: high io BUT huge amount of free memory