| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Joshua Brindle <joshua(dot)brindle(at)crunchydata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Joe Conway <joe(at)crunchydata(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: New Object Access Type hooks |
| Date: | 2022-03-21 19:57:34 |
| Message-ID: | 516E8A9F-76AA-4C08-BDE6-259D62060D62@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mar 18, 2022, at 3:04 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> I haven't looked at it in detail, but regarding the test code I'm not
> sure why there's a .control file, since this isn't a loadable extension,
> not why there's a test_oat_hooks.h file.
The .control file exists because the test defines a loadable module which defines the hooks. The test_oat_hooks.h file was extraneous, and has been removed in v2.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-String-object-access-hooks.patch | application/octet-stream | 10.8 KB |
| v2-0002-Add-regression-tests-of-Object-Access-Type-hooks.patch | application/octet-stream | 58.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2022-03-21 19:58:32 | Re: New Object Access Type hooks |
| Previous Message | Alvaro Herrera | 2022-03-21 19:03:07 | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |