| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Joshua Brindle <joshua(dot)brindle(at)crunchydata(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Joe Conway <joe(at)crunchydata(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: New Object Access Type hooks |
| Date: | 2022-03-21 19:58:32 |
| Message-ID: | 0169FE2F-3448-4F13-A0D8-0982C4086EE6@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mar 21, 2022, at 8:41 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> My first inclination is to say it's probably ok. The immediately obvious
> alternative would be to create yet another set of functions that don't
> have classId parameters. That doesn't seem attractive.
>
> Modulo that issue I think patch 1 is basically ok, but we should fix the
> comments in objectaccess.c. Rather than "It is [the] entrypoint ..." we
> should have something like "Oid variant entrypoint ..." and "Name
> variant entrypoint ...", and also fix the function names in the comments.
Joshua,
Do you care to create a new version of this, perhaps based on the v2-0001 patch I just posted?
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2022-03-21 20:09:09 | Re: jsonpath syntax extensions |
| Previous Message | Mark Dilger | 2022-03-21 19:57:34 | Re: New Object Access Type hooks |