| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Disabling src/test/[ssl|ldap] when not building with SSL/LDAP support |
| Date: | 2018-02-16 20:32:46 |
| Message-ID: | 511e9de9-0d72-96b3-ae90-67ee2c87b694@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/12/18 23:00, Michael Paquier wrote:
> Hm. Wouldn't it be enough to just spread the use of
> TestLib::check_pg_config and use SKIP on the tests where things cannot
> be run then? I see no need to invent an extra facility if all the
> control is already in pg_config.h. For slapd, you can actually just
> check if it can be executed in the PATH defined at the top of
> 001_auth.pl in $slapd, and skip the tests if the thing cannot be run.
> We have enough flexibility in perl and TAP to allow that to work
> reliably.
Maybe that would work.
We still need a way to configure whether we want to run tests that open
TCP/IP listen sockets.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-02-16 20:47:21 | Re: rename sgml files? |
| Previous Message | Peter Eisentraut | 2018-02-16 20:30:15 | Re: FOR EACH ROW triggers on partitioned tables |