| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Disabling src/test/[ssl|ldap] when not building with SSL/LDAP support |
| Date: | 2018-02-16 23:34:41 |
| Message-ID: | 20180216233441.GA21104@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 16, 2018 at 03:32:46PM -0500, Peter Eisentraut wrote:
> Maybe that would work.
>
> We still need a way to configure whether we want to run tests that open
> TCP/IP listen sockets.
For this an environment variable seems suited to me. Say if
PG_TAP_ALLOW_INSECURE is set, then the tests said "insecure" are allowed
to run. If the tests are tried to be run, then they are just skipped
with a nice log message to tell you about it. The cool part about this
design is that all the tests that are not part of check-world could be
integrated in it. Most developers don't run regression tests on a
shared resource. Let me think about a full-fledged patch first.
Documentation also matters a lot.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-02-17 00:03:37 | Re: pgsql: Do execGrouping.c via expression eval machinery, take two. |
| Previous Message | Tomas Vondra | 2018-02-16 23:23:40 | Re: ALTER TABLE ADD COLUMN fast default |