| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | 1584171677(at)qq(dot)com, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #7811: strlen(NULL) cause psql crash |
| Date: | 2013-01-15 19:01:13 |
| Message-ID: | 50F5A779.5060304@vmware.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 15.01.2013 20:29, Tom Lane wrote:
> Heikki Linnakangas<hlinnakangas(at)vmware(dot)com> writes:
>> On 15.01.2013 20:10, Tom Lane wrote:
>>> I think that patch could use more thought. As is, it will print
>>> connect to new database (currently "none")
>>> which to me is claiming that we are connected to a database whose name
>>> is "none". The quotes should not be used in this situation, and in
>>> fact it would be better for translatability if the whole message text
>>> were specialized to this case. I'd like to see it reading more like
>>> connect to new database (currently no connection)
>
>> Hmm, that'd introduce a new quite visible string into back-branches that
>> needs to be translated, which I think we try to avoid.
>
> But you already introduced "none" as a stand-alone (and probably almost
> untranslatable without context) string. That's better?
I figured it would be. One little untranslated string in parens, versus
the whole is untranslated. I'm happy to change it if you feel otherwise,
though, I don't feel strongly about it myself.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2013-01-15 19:03:39 | Re: BUG #7803: Replication Problem(no master is there) |
| Previous Message | Tom Lane | 2013-01-15 18:29:21 | Re: BUG #7811: strlen(NULL) cause psql crash |