| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | 1584171677(at)qq(dot)com, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #7811: strlen(NULL) cause psql crash |
| Date: | 2013-01-15 18:29:21 |
| Message-ID: | 29520.1358274561@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> On 15.01.2013 20:10, Tom Lane wrote:
>> I think that patch could use more thought. As is, it will print
>> connect to new database (currently "none")
>> which to me is claiming that we are connected to a database whose name
>> is "none". The quotes should not be used in this situation, and in
>> fact it would be better for translatability if the whole message text
>> were specialized to this case. I'd like to see it reading more like
>> connect to new database (currently no connection)
> Hmm, that'd introduce a new quite visible string into back-branches that
> needs to be translated, which I think we try to avoid.
But you already introduced "none" as a stand-alone (and probably almost
untranslatable without context) string. That's better?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2013-01-15 19:01:13 | Re: BUG #7811: strlen(NULL) cause psql crash |
| Previous Message | Heikki Linnakangas | 2013-01-15 18:17:20 | Re: BUG #7811: strlen(NULL) cause psql crash |