From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Problematic dependency in plpython Makefile [Windows] |
Date: | 2013-01-03 04:34:36 |
Message-ID: | 50E50A5C.6000408@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 01/02/2013 10:13 PM, Noah Misch wrote:
> On Windows, src/pl/plpython/Makefile has a rule whose target line expands to
> something like "python33.def: C:/Windows/system32/python33.dll". When doing a
> MinGW build with Cygwin's make-3.81, that line elicits an error:
>
> Makefile:69: *** target pattern contains no `%'. Stop.
>
> Seeing a second colon, make treats the line as a static pattern rule. Perhaps
> the MinGW project ships a make patched to avoid this, or perhaps folks
> building PostgreSQL override WINDIR. In any event, that dependency is not
> useful: we can't build the named file if it's absent, and an error from
> pexports is a good as an error from make. Let's drop the dependency.
>
> Note that this affects --without-python builds during "make clean".
>
>
>
I suspect under Msys the path seen won't contain a colon - it will be an
Msys virtualized path like /c/Windows/system32/....
Frankly, this is an unsupported toolchain. The supported toolchains
under Windows are Msys/Mingw and the Microsoft toolsets.
OTOH, I don't object to dropping a dependency that is truly useless.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2013-01-03 04:58:10 | Re: Problematic dependency in plpython Makefile [Windows] |
Previous Message | Fabrízio de Royes Mello | 2013-01-03 04:08:26 | Re: Proposal: Store "timestamptz" of database creation on "pg_database" |