From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Problematic dependency in plpython Makefile [Windows] |
Date: | 2013-01-03 03:13:58 |
Message-ID: | 20130103031358.GB11705@tornado.leadboat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Windows, src/pl/plpython/Makefile has a rule whose target line expands to
something like "python33.def: C:/Windows/system32/python33.dll". When doing a
MinGW build with Cygwin's make-3.81, that line elicits an error:
Makefile:69: *** target pattern contains no `%'. Stop.
Seeing a second colon, make treats the line as a static pattern rule. Perhaps
the MinGW project ships a make patched to avoid this, or perhaps folks
building PostgreSQL override WINDIR. In any event, that dependency is not
useful: we can't build the named file if it's absent, and an error from
pexports is a good as an error from make. Let's drop the dependency.
Note that this affects --without-python builds during "make clean".
Thanks,
nm
Attachment | Content-Type | Size |
---|---|---|
plpython-bad-dependency-v1.patch | text/plain | 780 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2013-01-03 03:52:58 | Re: Problematic dependency in plpython Makefile [Windows] |
Previous Message | Stephen Frost | 2013-01-03 02:12:06 | Re: Proposal: Store "timestamptz" of database creation on "pg_database" |