Re: pgsql: Get rid of backtracking in jsonpath_scan.l

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Get rid of backtracking in jsonpath_scan.l
Date: 2019-03-26 12:31:15
Message-ID: 5083bd0a-7cc4-fff3-284b-7492a830fa1d@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 3/25/19 8:44 AM, Alexander Korotkov wrote:
> Get rid of backtracking in jsonpath_scan.l
>
> Non-backtracking flex parsers work faster than backtracking ones. So, this
> commit gets rid of backtracking in jsonpath_scan.l. That required explicit
> handling of some cases as well as manual backtracking for some cases. More
> regression tests for numerics are added.

jacana appears to be having trouble with this:

2019-03-26 00:49:02.208 EDT [5c99ae9e.20cc:6] LOG: server process (PID 8368) was terminated by exception 0xC0000028
2019-03-26 00:49:02.208 EDT [5c99ae9e.20cc:7] DETAIL: Failed process was running: select '$ ? (@ like_regex "pattern" flag "a")'::jsonpath;
2019-03-26 00:49:02.208 EDT [5c99ae9e.20cc:8] HINT: See C include file "ntstatus.h" for a description of the hexadecimal value.
2019-03-26 00:49:02.208 EDT [5c99ae9e.20cc:9] LOG: terminating any other active server processes

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2019-03-26 12:32:08 pgsql: Fix typo
Previous Message Peter Eisentraut 2019-03-26 08:32:27 pgsql: Fix misplaced const

Browse pgsql-hackers by date

  From Date Subject
Next Message Lucas Viecelli 2019-03-26 12:36:10 Re: warning to publication created and wal_level is not set to logical
Previous Message Surafel Temesgen 2019-03-26 12:06:52 Re: FETCH FIRST clause PERCENT option