Re: _USE_32BIT_TIME_T Patch

On 08/31/2012 03:36 PM, Tom Lane wrote:
> Dave Page <dpage(at)pgadmin(dot)org> writes:
>> As a side note - I'm not sure why _USE_32BIT_TIME_T was removed in the
>> first place; it was added specifically to avoid this sort of problem,
>> though iirc at the time we were thinking of extensions like Slony and
>> PostGIS being built with Mingw for use with the VC++ built server.
> We removed it when we changed our internal time_t usage to 64 bits:
> http://git.postgresql.org/gitweb/?p=postgresql.git&a=commitdiff&h=cd004067742ee16ee63e55abfb4acbd5f09fbaab
> Possibly that was just a brain fade caused by failing to think about
> the distinction between pg_time_t and system time_t. However, the
> code has been like that since 8.4, and nobody complained before.
> I share Andrew's unease about whether this issue is fully understood.
>
>

OTOH, the fact that we used to have it and nothing broke that we know of
is somewhat reassuring.

I'm not sure what we need to do to progress on this, especially re the
back branches.

cheers

andrew