From: | Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru> |
---|---|
To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
Date: | 2024-12-09 21:01:43 |
Message-ID: | 4e2764f7-f6be-478f-8d7f-f921dbd10f5f@postgrespro.ru |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thank you for email!
>The patches currently doesn't apply cleanly. Please, rebase.
I did rebase and made few fixes that were needed after the recent
vanilla changes (added ATT_PARTITIONED_TABLE flag for
ATSimplePermissions function + added creation of not-null constraints in
the createTableConstraints function).
The patches are attached to the email.
>I think the code requires some polishing: you need to revise
> the comments given its not part of LIKE clause handling anymore.
I removed couple of lines from comment and a few lines from
documentation, I hope that's enough ...
>I see fixes for the issues mentioned in [1] and [2] are still not
>implemented. Do you plan to do this in this release cycle?
I would like to make some changes, but I think it would be appropriate
to discuss these points first.
As far as I understand, there is currently no clear opinion on how to
implement [1] and [2].
I would appreciate your opinions on what improvements are really needed
and in what order they should be implemented.
--
With best regards,
Dmitry Koval
Postgres Professional: http://postgrespro.com
Attachment | Content-Type | Size |
---|---|---|
v34-0001-Implement-ALTER-TABLE-.-MERGE-PARTITIONS-.-comma.patch | text/plain | 138.8 KB |
v34-0002-Implement-ALTER-TABLE-.-SPLIT-PARTITION-.-comman.patch | text/plain | 206.5 KB |
v34-0003-Refactor-createPartitionTable-to-remove-ProcessU.patch | text/plain | 19.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2024-12-09 21:37:58 | Re: Replace current implementations in crypt() and gen_salt() to OpenSSL |
Previous Message | Heikki Linnakangas | 2024-12-09 20:55:45 | Re: Refactoring postmaster's code to cleanup after child exit |