Re: Replace current implementations in crypt() and gen_salt() to OpenSSL

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, "Koshi Shibagaki (Fujitsu)" <shibagaki(dot)koshi(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Replace current implementations in crypt() and gen_salt() to OpenSSL
Date: 2024-12-09 21:37:58
Message-ID: 18FCEDA2-3409-4ED0-BF05-7A7F433C993B@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 9 Dec 2024, at 15:11, Joe Conway <mail(at)joeconway(dot)com> wrote:
>
> On 12/9/24 07:23, Daniel Gustafsson wrote:
>>> On 4 Dec 2024, at 16:57, Joe Conway <mail(at)joeconway(dot)com> wrote:
>>> I can send you the source RPM for openssl 1.1.1c which was an earlier FIPS validated version, but the main FIPS patch contains:
>> AFAICT the forks of 1.1.1 which offer FIPS certification all patch the common
>> OpenSSL API FIPS_mode() rather than invent a new one, so the earlier approach
>> should work fine. PFA an updated version which I propose we go ahead with.
>
> That sounds correct from my memory of it.
>
> I have not done any actual testing (yet), but on quick scan this part looks suspicious:

Not only suspicious but plain wrong, fixed in the attached, thanks!

--
Daniel Gustafsson

Attachment Content-Type Size
v5-0001-pgcrypto-Make-it-possible-to-disable-built-in-cry.patch application/octet-stream 8.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2024-12-09 21:42:58 Managing IO workers in postmaster's state machine
Previous Message Dmitry Koval 2024-12-09 21:01:43 Re: Add SPLIT PARTITION/MERGE PARTITIONS commands